C_SHARP_SKILLS/.ai/skills/17-code-review-definition-of-done.md

Skill 17 - Code Review and Definition of Done

Review Checklist

• The change satisfies the stated requirement.
• The solution follows existing architecture and naming conventions.
• Public APIs are documented or self-explanatory.
• Nullable warnings are resolved, not suppressed without reason.
• Exceptions are handled at appropriate boundaries.
• External input is validated.
• Secrets are not hardcoded.
• Async code is not blocked.
• Resources are disposed.
• Database queries are efficient and safe.
• If using Unit of Work: all repositories in a logical operation share one DbContext; SaveChangesAsync is called once per operation at the Unit of Work boundary.
• Tests cover meaningful behavior and edge cases.
• dotnet build succeeds.
• dotnet test succeeds or exact blockers are reported.
• The final response lists changed files, commands run, assumptions, and remaining risks.

Definition of Done

A C#/.NET task is done when:

1. The code compiles.
2. Existing tests pass.
3. New behavior is covered by tests or there is a stated reason it cannot be tested here.
4. Security and nullability concerns are addressed.
5. The implementation is no larger than needed.
6. The user can reproduce the result with provided commands.