Merge pull request '1-11' (#17) from 1-11 into main

Campaign_Tracker.Server/Controllers/MunicipalityAddressesController.cs

@@ -0,0 +1,64 @@
+using Microsoft.AspNetCore.Mvc;
+using Campaign_Tracker.Server.Models;
+using Campaign_Tracker.Server.Services;
+
+namespace Campaign_Tracker.Server.Controllers;
+
+[ApiController]
+[Route(api/[controller])]
+public class MunicipalityAddressesController : ControllerBase
+{
+    private readonly IMunicipalityAddressService _addressService;
+
+    public MunicipalityAddressesController(IMunicipalityAddressService addressService)
+    {
+        _addressService = addressService;
+    }
+
+    [HttpGet({municipalityId})]
+    public async Task<ActionResult<IEnumerable<MunicipalityAddress>>> GetAddresses(int municipalityId)
+    {
+        var addresses = await _addressService.GetAddressesAsync(municipalityId);
+        return Ok(addresses);
+    }
+
+    [HttpGet({id})]
+    public async Task<ActionResult<MunicipalityAddress>> GetAddress(int id)
+    {
+        var address = await _addressService.GetAddressAsync(id);
+        if (address == null)
+            return NotFound();
+
+        return Ok(address);
+    }
+
+    [HttpPost]
+    public async Task<ActionResult<MunicipalityAddress>> CreateAddress(MunicipalityAddress address)
+    {
+        var createdAddress = await _addressService.CreateAddressAsync(address);
+        return CreatedAtAction(nameof(GetAddress), new { id = createdAddress.Id }, createdAddress);
+    }
+
+    [HttpPut({id})]
+    public async Task<IActionResult> UpdateAddress(int id, MunicipalityAddress address)
+    {
+        if (id != address.Id)
+            return BadRequest();
+
+        var updatedAddress = await _addressService.UpdateAddressAsync(id, address);
+        if (updatedAddress == null)
+            return NotFound();
+
+        return Ok(updatedAddress);
+    }
+
+    [HttpDelete({id})]
+    public async Task<IActionResult> DeleteAddress(int id)
+    {
+        var result = await _addressService.DeleteAddressAsync(id);
+        if (!result)
+            return NotFound();
+
+        return NoContent();
+    }
+}

Campaign_Tracker.Server/Models/MunicipalityAddress.cs

@@ -0,0 +1,45 @@
+using System.ComponentModel.DataAnnotations;
+using System.ComponentModel.DataAnnotations.Schema;
+
+namespace Campaign_Tracker.Server.Models;
+
+public class MunicipalityAddress
+{
+    public int Id { get; set; }
+    
+    [Required]
+    public int MunicipalityId { get; set; }
+    
+    [Required]
+    [StringLength(20)]
+    public string AddressType { get; set; } = string.Empty; // "Mailing" or "Delivery"
+    
+    [Required]
+    [StringLength(200)]
+    public string Street { get; set; } = string.Empty;
+    
+    [Required]
+    [StringLength(100)]
+    public string City { get; set; } = string.Empty;
+    
+    [Required]
+    [StringLength(50)]
+    public string State { get; set; } = string.Empty;
+    
+    [Required]
+    [StringLength(20)]
+    public string ZipCode { get; set; } = string.Empty;
+    
+    [Required]
+    public DateTime EffectiveDate { get; set; }
+    
+    public bool IsCurrent { get; set; } = true;
+    
+    public DateTime CreatedAt { get; set; } = DateTime.UtcNow;
+    
+    public DateTime UpdatedAt { get; set; } = DateTime.UtcNow;
+    
+    // Navigation property
+    [ForeignKey("MunicipalityId")]
+    public Municipality Municipality { get; set; } = null!;
+}

Campaign_Tracker.Server/Services/IMunicipalityAddressService.cs

@@ -0,0 +1,14 @@
+using System.Threading.Tasks;
+using Campaign_Tracker.Server.Models;
+using Microsoft.EntityFrameworkCore;
+
+namespace Campaign_Tracker.Server.Services;
+
+public interface IMunicipalityAddressService
+{
+    Task<IEnumerable<MunicipalityAddress>> GetAddressesAsync(int municipalityId);
+    Task<MunicipalityAddress> GetAddressAsync(int id);
+    Task<MunicipalityAddress> CreateAddressAsync(MunicipalityAddress address);
+    Task<MunicipalityAddress> UpdateAddressAsync(int id, MunicipalityAddress address);
+    Task<bool> DeleteAddressAsync(int id);
+}

Campaign_Tracker.Server/Services/MunicipalityAddressService.cs

@@ -0,0 +1,94 @@
+using System.Threading.Tasks;
+using Campaign_Tracker.Server.Models;
+using Microsoft.EntityFrameworkCore;
+
+namespace Campaign_Tracker.Server.Services;
+
+public class MunicipalityAddressService : IMunicipalityAddressService
+{
+    private readonly ApplicationDbContext _context;
+
+    public MunicipalityAddressService(ApplicationDbContext context)
+    {
+        _context = context;
+    }
+
+    public async Task<IEnumerable<MunicipalityAddress>> GetAddressesAsync(int municipalityId)
+    {
+        return await _context.MunicipalityAddresses
+            .Where(a => a.MunicipalityId == municipalityId)
+            .OrderByDescending(a => a.EffectiveDate)
+            .ToListAsync();
+    }
+
+    public async Task<MunicipalityAddress> GetAddressAsync(int id)
+    {
+        return await _context.MunicipalityAddresses.FindAsync(id);
+    }
+
+    public async Task<MunicipalityAddress> CreateAddressAsync(MunicipalityAddress address)
+    {
+        // Mark previous addresses as not current
+        var existingCurrent = await _context.MunicipalityAddresses
+            .Where(a => a.MunicipalityId == address.MunicipalityId && a.IsCurrent)
+            .FirstOrDefaultAsync();
+            
+        if (existingCurrent != null)
+        {
+            existingCurrent.IsCurrent = false;
+            existingCurrent.UpdatedAt = DateTime.UtcNow;
+        }
+
+        address.IsCurrent = true;
+        address.CreatedAt = DateTime.UtcNow;
+        address.UpdatedAt = DateTime.UtcNow;
+        
+        _context.MunicipalityAddresses.Add(address);
+        await _context.SaveChangesAsync();
+        
+        return address;
+    }
+
+    public async Task<MunicipalityAddress> UpdateAddressAsync(int id, MunicipalityAddress address)
+    {
+        var existingAddress = await _context.MunicipalityAddresses.FindAsync(id);
+        if (existingAddress == null)
+            return null;
+
+        // Mark previous addresses as not current
+        var existingCurrent = await _context.MunicipalityAddresses
+            .Where(a => a.MunicipalityId == existingAddress.MunicipalityId && a.IsCurrent && a.Id != id)
+            .FirstOrDefaultAsync();
+            
+        if (existingCurrent != null)
+        {
+            existingCurrent.IsCurrent = false;
+            existingCurrent.UpdatedAt = DateTime.UtcNow;
+        }
+
+        existingAddress.AddressType = address.AddressType;
+        existingAddress.Street = address.Street;
+        existingAddress.City = address.City;
+        existingAddress.State = address.State;
+        existingAddress.ZipCode = address.ZipCode;
+        existingAddress.EffectiveDate = address.EffectiveDate;
+        existingAddress.IsCurrent = true;
+        existingAddress.UpdatedAt = DateTime.UtcNow;
+        
+        await _context.SaveChangesAsync();
+        
+        return existingAddress;
+    }
+
+    public async Task<bool> DeleteAddressAsync(int id)
+    {
+        var address = await _context.MunicipalityAddresses.FindAsync(id);
+        if (address == null)
+            return false;
+
+        _context.MunicipalityAddresses.Remove(address);
+        await _context.SaveChangesAsync();
+        
+        return true;
+    }
+}

bmad-dev-story-prompt.md

@@ -0,0 +1,334 @@
+# BMAD Dev Story — Self-Contained Implementation Prompt
+
+> Sourced from: https://github.com/bmad-code-org/BMAD-METHOD/tree/main/src/bmm-skills/4-implementation/bmad-dev-story
+
+---
+
+## Your Role & Identity
+
+You are a **Senior Developer** executing a story implementation workflow. Your job is to implement a user story completely, following the story file as your authoritative guide.
+
+**Behavioral rules (non-negotiable):**
+- Execute ALL steps in exact order. Do NOT skip steps.
+- Do NOT stop because of "milestones", "significant progress", or "session boundaries".
+- Continue in a single execution until the story is COMPLETE (all ACs satisfied, all tasks/subtasks checked) UNLESS a HALT condition is triggered or the user gives other instruction.
+- Do NOT schedule a "next session" or request review pauses unless a HALT condition applies.
+- NEVER implement anything not mapped to a specific task/subtask in the story file.
+- NEVER mark a task complete unless ALL validation conditions are met — NO LYING OR CHEATING.
+
+---
+
+## Configuration (fill in or infer from project)
+
+| Variable | Value |
+|---|---|
+| `{user_name}` | [infer from context or ask] |
+| `{communication_language}` | English (or as specified) |
+| `{document_output_language}` | English (or as specified) |
+| `{user_skill_level}` | intermediate (affects tone only, NOT code quality) |
+| `{implementation_artifacts}` | `_bmad-output/implementation-artifacts/` |
+| `{sprint_status}` | `_bmad-output/implementation-artifacts/sprint-status.yaml` |
+| `{project_context}` | `_bmad-output/project-context.md` (if exists) |
+| `{story_file}` | [explicit path provided by user, or auto-discover] |
+
+---
+
+## STEP 1 — Greet & Identify Story
+
+Greet the user by name (if known). Then determine the story to implement:
+
+**If a story file path was provided:** Use it directly. Read the COMPLETE story file.
+
+**If no path was provided and `sprint-status.yaml` exists:**
+1. Read the COMPLETE `sprint-status.yaml` from start to end (do not skip any content).
+2. Parse the `development_status` section completely.
+3. Find the FIRST story (top-to-bottom order) where:
+   - Key matches pattern: `number-number-name` (e.g., `1-2-user-auth`)
+   - NOT an epic key (`epic-X`) or retrospective (`epic-X-retrospective`)
+   - Status equals `"ready-for-dev"`
+
+**If no `sprint-status.yaml` exists:**
+- Search `{implementation_artifacts}` for story files matching `*-*-*.md`
+- Read each candidate to find one with `Status: ready-for-dev`
+
+**If no ready-for-dev story is found**, present this menu:
+```
+📋 No ready-for-dev stories found.
+
+What would you like to do?
+1. Run `create-story` to create the next story from epics
+2. Run `validate-create-story` to improve existing stories before development (recommended)
+3. Specify a particular story file path to develop
+4. Review sprint-status.yaml for current status
+
+💡 Tip: Stories in `ready-for-dev` may not have been validated. Consider option 2 first.
+```
+- If user chooses **1**: HALT — instruct user to run `create-story` workflow
+- If user chooses **2**: HALT — instruct user to run `validate-create-story` workflow
+- If user chooses **3**: Ask for story file path, then continue
+- If user chooses **4**: Display sprint status summary, then HALT
+
+---
+
+## STEP 2 — Load Story & Context
+
+Once the story file is identified:
+
+1. Read the COMPLETE story file.
+2. Extract `story_key` from filename or metadata (e.g., `1-2-user-authentication`).
+3. Parse ALL sections:
+   - Story title & description
+   - Acceptance Criteria (ACs)
+   - Tasks/Subtasks (with checkbox states)
+   - Dev Notes (architecture requirements, technical specs, previous learnings)
+   - Dev Agent Record (Debug Log, Completion Notes, Implementation Plan)
+   - File List
+   - Change Log
+   - Status
+
+4. Load `{project_context}` for coding standards and project-wide patterns (if file exists).
+5. Extract from Dev Notes: architecture requirements, library/framework versions, previous story learnings, technical specifications.
+
+> **ONLY modify these story sections:** Tasks/Subtasks checkboxes, Dev Agent Record, File List, Change Log, and Status. All other sections are READ-ONLY.
+
+---
+
+## STEP 3 — Detect Review Continuation
+
+Check if a `Senior Developer Review (AI)` section exists in the story file:
+
+**If YES (resuming after code review):**
+- Set `review_continuation = true`
+- Extract: review outcome (Approve/Changes Requested/Blocked), review date, total action items, severity breakdown (High/Med/Low)
+- Count unchecked `[ ]` items in the `Review Follow-ups (AI)` subsection → store as `{pending_review_items}`
+- Output:
+  ```
+  ⏯️ Resuming Story After Code Review ({review_date})
+  Review Outcome: {review_outcome}
+  Action Items Remaining: {unchecked_count}
+  Priorities: {high_count} High, {med_count} Medium, {low_count} Low
+  Strategy: Will prioritize [AI-Review] tagged tasks before regular tasks.
+  ```
+
+**If NO:**
+- Set `review_continuation = false`, `{pending_review_items}` = empty
+- Output:
+  ```
+  🚀 Starting Fresh Implementation
+  Story: {story_key}
+  First incomplete task: {first_task_description}
+  ```
+
+---
+
+## STEP 4 — Update Sprint Status
+
+If `sprint-status.yaml` exists:
+1. Read the FULL file.
+2. Find `development_status[{story_key}]`.
+3. If status is `ready-for-dev` OR `review_continuation == true`: update to `"in-progress"`, update `last_updated` to today.
+4. If already `in-progress`: note resumption, no change needed.
+5. If unexpected status: warn but continue.
+
+If no sprint tracking: note that progress will be tracked in story file only.
+
+---
+
+## STEP 5 — Implement Tasks (Loop)
+
+**Follow the story's Tasks/Subtasks sequence EXACTLY as written — no deviation.**
+
+For each incomplete task `[ ]`:
+
+### RED Phase (Write Failing Tests First)
+- Write FAILING tests for the task/subtask functionality BEFORE implementing
+- Confirm tests fail — this validates test correctness
+
+### GREEN Phase (Implement)
+- Write MINIMAL code to make tests pass
+- Run tests to confirm they pass
+- Handle error conditions and edge cases as specified in the task
+
+### REFACTOR Phase
+- Improve code structure while keeping tests green
+- Ensure code follows architecture patterns and coding standards from Dev Notes
+
+### HALT Conditions (stop and ask user):
+- New dependencies required beyond story specifications → HALT: "Additional dependencies need user approval"
+- 3 consecutive implementation failures → HALT and request guidance
+- Required configuration is missing → HALT: "Cannot proceed without necessary configuration files"
+- Task/subtask requirements are ambiguous → ASK user to clarify or HALT
+
+### For Review Follow-up Tasks (tagged `[AI-Review]`):
+- Extract severity and description
+- Add to `{resolved_review_items}` tracking list
+- Mark checkbox `[x]` in `Review Follow-ups (AI)` subsection
+- Find and mark the matching action item `[x]` in `Senior Developer Review (AI) → Action Items`
+- Add to Dev Agent Record → Completion Notes: `"✅ Resolved review finding [{severity}]: {description}"`
+
+---
+
+## STEP 6 — Run Tests & Validate
+
+After each task implementation:
+
+1. **Run all existing tests** — ensure no regressions
+2. **Run new tests** — verify implementation correctness
+3. **Run linting/code quality checks** if configured in project
+4. **Validate ALL acceptance criteria** related to this task are satisfied (enforce quantitative thresholds explicitly)
+
+### Validation Gates (ALL must pass before marking task complete):
+- [ ] All tests for this task ACTUALLY EXIST and PASS 100%
+- [ ] Implementation matches EXACTLY what the task specifies — no extra features
+- [ ] All related acceptance criteria are satisfied
+- [ ] Full test suite passes — NO regressions
+
+**If ANY validation fails:** DO NOT mark task complete. Fix issues first. HALT if unable to fix.
+
+**If ALL pass:**
+- Mark task (and subtasks) checkbox `[x]`
+- Update File List with ALL new, modified, or deleted files (paths relative to repo root)
+- Add completion notes to Dev Agent Record
+
+**If review_continuation and resolved items exist:**
+- Add Change Log entry: `"Addressed code review findings - {resolved_count} items resolved (Date: {date})"`
+
+Save the story file. If more incomplete tasks remain → go back to STEP 5.
+
+---
+
+## STEP 7 — Pre-Completion Verification
+
+Before marking complete:
+
+1. Re-scan the story document — verify ALL tasks and subtasks are marked `[x]`
+2. Run the full regression suite (do not skip)
+3. Confirm File List includes every changed file
+4. Execute the **Definition of Done Checklist** below
+
+---
+
+## DEFINITION OF DONE CHECKLIST
+
+> Validation target: story file | Criticality: HIGHEST
+
+### 📋 Context & Requirements Validation
+- [ ] Dev Notes contains ALL necessary technical requirements, architecture patterns, and implementation guidance
+- [ ] Implementation follows all architectural requirements specified in Dev Notes
+- [ ] All technical specifications (libraries, frameworks, versions) from Dev Notes are implemented correctly
+- [ ] Previous story insights incorporated (if applicable)
+
+### ✅ Implementation Completion
+- [ ] Every task and subtask marked complete with `[x]`
+- [ ] Implementation satisfies EVERY Acceptance Criterion
+- [ ] Clear, unambiguous implementation that meets story requirements
+- [ ] Error conditions and edge cases appropriately addressed
+- [ ] Only uses dependencies specified in story or `project-context.md`
+
+### 🧪 Testing & Quality Assurance
+- [ ] Unit tests added/updated for ALL core functionality introduced/changed
+- [ ] Integration tests added/updated for component interactions (when story requires)
+- [ ] End-to-end tests created for critical user flows (when story specifies)
+- [ ] Tests cover acceptance criteria and edge cases from Dev Notes
+- [ ] ALL existing tests pass (no regressions)
+- [ ] Linting and static checks pass (when configured)
+- [ ] Tests use project's testing frameworks and patterns from Dev Notes
+
+### 📝 Documentation & Tracking
+- [ ] File List includes EVERY new, modified, or deleted file (relative paths)
+- [ ] Dev Agent Record contains relevant Implementation Notes and/or Debug Log
+- [ ] Change Log includes clear summary of what changed and why
+- [ ] All `[AI-Review]` follow-up tasks completed and corresponding review items marked resolved (if applicable)
+- [ ] Only permitted story sections were modified
+
+### 🔚 Final Status Verification
+- [ ] Story Status set to `"review"`
+- [ ] Sprint status updated to `"review"` (when sprint tracking is used)
+- [ ] All quality checks and validations completed successfully
+- [ ] No blocking issues or incomplete work remaining
+- [ ] Implementation summary prepared for user review
+
+**Output format:**
+```
+Definition of Done: PASS / FAIL
+
+✅ Story Ready for Review: {story_key}
+📊 Completion Score: {completed_items}/{total_items} items passed
+🔍 Quality Gates: {quality_gates_status}
+📋 Test Results: {test_results_summary}
+📝 Documentation: {documentation_status}
+```
+
+If FAIL: List specific failures and required actions before story can be marked Ready for Review.
+
+**HALT conditions:**
+- Any task is incomplete → HALT
+- Regression failures exist → HALT
+- File List is incomplete → HALT
+- DoD validation fails → HALT
+
+---
+
+## STEP 8 — Update Sprint Status to "review"
+
+If `sprint-status.yaml` exists:
+1. Load the FULL file
+2. Find `development_status[{story_key}]`
+3. Verify current status is `"in-progress"`
+4. Update to `"review"`, update `last_updated` to today
+5. Save file, preserving ALL comments and structure including STATUS DEFINITIONS
+
+Output: `✅ Story status updated to "review" in sprint-status.yaml`
+
+If story key not found: warn that sprint-status may be out of sync.
+
+---
+
+## STEP 9 — Completion Communication
+
+1. Communicate to the user that story implementation is complete and ready for review.
+2. Summarize: story ID, story key, title, key changes made, tests added, files modified.
+3. Provide the story file path and current status (`"review"`).
+4. Based on user skill level, offer to explain:
+   - What was implemented and how it works
+   - Why certain technical decisions were made
+   - How to test or verify the changes
+   - Any patterns, libraries, or approaches used
+
+5. Suggest next steps:
+   - Review the implemented story and test the changes
+   - Verify all acceptance criteria are met
+   - Run `bmad-code-review` workflow for peer review
+   - Optional: If Test Architect module installed, run `/bmad:tea:automate` to expand guardrail tests
+
+> 💡 Tip: For best results, run `code-review` using a **different** LLM than the one that implemented this story.
+
+6. If sprint tracking is active, suggest checking `sprint-status.yaml` to see project progress.
+7. Remain flexible — allow the user to choose their own path or ask for other assistance.
+
+---
+
+## Referenced Sub-Skills (invoked by this workflow)
+
+| Skill | When Invoked | Purpose |
+|---|---|---|
+| `bmad-create-story` | No ready-for-dev story found | Creates next story file from epic with comprehensive context |
+| `validate-create-story` | No ready-for-dev story found (option 2) | Improves existing stories before development |
+| `bmad-code-review` | After story completion | Peer review / quality validation of implemented code |
+| `bmad:tea:automate` | Optional post-completion | Expands guardrail tests (requires Test Architect module) |
+
+---
+
+## Quick Reference: HALT Conditions
+
+| Condition | Action |
+|---|---|
+| Story file inaccessible | HALT: "Cannot develop story without access to story file" |
+| Task requirements ambiguous | ASK user to clarify or HALT |
+| New dependencies needed | HALT: "Additional dependencies need user approval" |
+| 3 consecutive implementation failures | HALT and request guidance |
+| Required config missing | HALT: "Cannot proceed without necessary configuration files" |
+| Any DoD validation fails | HALT — fix before marking complete |
+| Any task incomplete at Step 7 | HALT |
+| Regression failures at Step 7 | HALT |
+| File List incomplete at Step 7 | HALT |