From ab640277f61e4264697ad71dcca3e12317f7dd5a Mon Sep 17 00:00:00 2001 From: nano Date: Tue, 5 May 2026 17:30:41 +0000 Subject: [PATCH] Merge branch 1.2 into main (_bmad-output/implementation-artifacts/1-2-workspace-shell-ant-design-foundation.md) --- ...2-workspace-shell-ant-design-foundation.md | 53 ++++++++++++++----- 1 file changed, 40 insertions(+), 13 deletions(-) diff --git a/_bmad-output/implementation-artifacts/1-2-workspace-shell-ant-design-foundation.md b/_bmad-output/implementation-artifacts/1-2-workspace-shell-ant-design-foundation.md index a952f15..5dfa90c 100644 --- a/_bmad-output/implementation-artifacts/1-2-workspace-shell-ant-design-foundation.md +++ b/_bmad-output/implementation-artifacts/1-2-workspace-shell-ant-design-foundation.md @@ -1,6 +1,6 @@ # Story 1.2: Workspace Shell & Ant Design Foundation -Status: ready-for-dev +Status: review ## Story @@ -19,18 +19,18 @@ so that I have a predictable, accessible, and keyboard-navigable operational env ## Tasks / Subtasks -- [ ] Implement story behavior in aligned backend/frontend modules (AC: #1) - - [ ] Add or update API/service/UI components required by the story scope - - [ ] Keep legacy Access entities read-only and route writes to extension-layer structures -- [ ] Cover acceptance criteria #2 in implementation and tests (AC: #2) - - [ ] Add validation/error handling and UX state updates as needed -- [ ] Cover acceptance criteria #3 in implementation and tests (AC: #3) - - [ ] Add validation/error handling and UX state updates as needed -- [ ] Cover acceptance criteria #4 in implementation and tests (AC: #4) - - [ ] Add validation/error handling and UX state updates as needed -- [ ] Validate and document completion evidence - - [ ] Verify build/tests for touched modules - - [ ] Capture changed files and any migration/config implications +- [x] Implement story behavior in aligned backend/frontend modules (AC: #1) + - [x] Add or update API/service/UI components required by the story scope + - [x] Keep legacy Access entities read-only and route writes to extension-layer structures +- [x] Cover acceptance criteria #2 in implementation and tests (AC: #2) + - [x] Add validation/error handling and UX state updates as needed +- [x] Cover acceptance criteria #3 in implementation and tests (AC: #3) + - [x] Add validation/error handling and UX state updates as needed +- [x] Cover acceptance criteria #4 in implementation and tests (AC: #4) + - [x] Add validation/error handling and UX state updates as needed +- [x] Validate and document completion evidence + - [x] Verify build/tests for touched modules + - [x] Capture changed files and any migration/config implications ## Dev Notes @@ -59,13 +59,40 @@ GPT-5 Codex ### Debug Log References - Story generated from epic source and architecture/UX planning artifacts. +- 2026-05-05: Added failing frontend contract tests for workspace tokens, breakpoints, edit gating, right-panel collapse rules, and non-color-only statuses. +- 2026-05-05: Verified `npm test`, `npm run lint`, `npm run build`, and `dotnet test campaign-tracker.sln`. + +### Implementation Plan + +- Replace the starter Vite screen with an Ant Design `ConfigProvider` and tri-pane workspace shell. +- Centralize UX tokens, status semantics, and breakpoint rules in a tested workspace contract module. +- Keep backend and legacy data untouched for this shell story; expose only read-only operational sample context in the UI. ### Completion Notes List - Story context created and marked ready-for-dev. +- Implemented the authenticated operations workspace shell with Ant Design `ConfigProvider`, compact theme tokens, left navigation pane, center operations grid, and right risk/provenance panel. +- Added responsive desktop behavior: compact tri-pane with collapsible right panel from 1280px to 1599px, persistent right panel at 1600px+, and reduced read mode with disabled editing below 1280px. +- Added visible 2px focus indicators and status indicators that pair semantic colors with icons and text labels. +- No backend write path was added; legacy Access data is represented as read-only source context and future updates are labeled for extension records. ### File List +- `_bmad-output/implementation-artifacts/sprint-status.yaml` - `_bmad-output/implementation-artifacts/1-2-workspace-shell-ant-design-foundation.md` +- `campaign-tracker-client/package.json` +- `campaign-tracker-client/package-lock.json` +- `campaign-tracker-client/src/App.css` +- `campaign-tracker-client/src/App.tsx` +- `campaign-tracker-client/src/index.css` +- `campaign-tracker-client/src/main.tsx` +- `campaign-tracker-client/src/workspace/WorkspaceShell.css` +- `campaign-tracker-client/src/workspace/WorkspaceShell.tsx` +- `campaign-tracker-client/src/workspace/workspaceContracts.test.ts` +- `campaign-tracker-client/src/workspace/workspaceContracts.ts` + +### Change Log + +- 2026-05-05: Implemented Workspace Shell & Ant Design Foundation and marked story ready for review.