Daniel Covington 6a10f82863 fix(1.10): code review patches — concurrency, null-safety, test coverage Repository: - Add _lock to InMemoryMunicipalityProfileRepository; make duplicate-JCode check + insert atomic in CreateAsync (TOCTOU fix) and wrap UpdateAsync read-modify-write in lock (lost-update fix) - Normalize JCode before passing to ILegacyLinkValidator so validation and storage use the same form (was: raw input validated, ToUpperInvariant stored) - UpdateAsync returns ProfileNotFound (new factory on MunicipalityProfileSaveResult) so controller can distinguish 404 from 422 Controller: - Null-guard post-save/update GetByIdAsync result instead of bang-deref - Return 404 (not 422) when update target profile does not exist - GET /api/municipalities/jurisdictions accepted as in-scope extension Data access: - FromJsonSeedFile: catch(Exception ex) with Console.Error.WriteLine; DistinctBy(JCode) before projection to suppress duplicates in seed file - 422 body shape mismatch: problem.error ?? 'Validation failed.' fallback in createMunicipalityProfile and updateMunicipalityProfile Frontend: - Split Promise.all into independent profile + jurisdiction loads so a jurisdiction failure does not suppress the profile table - Add jurisdictionsLoadError state; disable "New" button and show warning alert when jurisdictions are unavailable Tests: - Override ILegacyDataAccess in AuthIntegrationTestFactory with hardcoded defaults, isolating integration tests from the development seed file - Add wrong-role 403, jurisdiction endpoint 401, update-not-found 404, and AC#3 audit assertion tests (create + update) to controller suite - Add fetchAvailableJurisdictions contract tests (success + failure) - Story 1.10 marked done; sprint-status synced		2 päivää sitten
.gitea/workflows	fix: close review findings for stories 1.7 and 1.8	3 päivää sitten
Campaign_Tracker.Server	fix(1.10): code review patches — concurrency, null-safety, test coverage	2 päivää sitten
Campaign_Tracker.Server.Tests	fix(1.10): code review patches — concurrency, null-safety, test coverage	2 päivää sitten
Initial Documents	init	4 päivää sitten
_bmad-output	fix(1.10): code review patches — concurrency, null-safety, test coverage	2 päivää sitten
campaign-tracker-client	fix(1.10): code review patches — concurrency, null-safety, test coverage	2 päivää sitten
docs	init	4 päivää sitten
.gitignore	fix: complete story 1.9 seed defaults	3 päivää sitten
Initial Description.txt	This Code is for Issues 1-1	4 päivää sitten
README.md	Fix Story 1.1 scaffold docs (README.md)	4 päivää sitten
campaign-tracker.sln	This Code is for Issues 1-1	4 päivää sitten
package-lock.json	fix: complete story 1.9 seed defaults	3 päivää sitten

README.md

Campaign_Tracker App

Prerequisites

.NET SDK 10.0+
Node.js 20.19+ (or 22.12+)

Run Commands

Server

dotnet restore .\campaign-tracker.sln
dotnet build .\campaign-tracker.sln
dotnet run --project .\Campaign_Tracker.Server\Campaign_Tracker.Server.csproj

Health check:

Invoke-WebRequest http://localhost:5254/health

Client

cd .\campaign-tracker-client
npm install
npm run dev

Tests

dotnet test .\campaign-tracker.sln
cd .\campaign-tracker-client
npm run lint
npm run build